Skip to content

Comments

Add azmcp sql server conn-policy show and unit tests#799

Draft
ericshape wants to merge 2 commits intomicrosoft:mainfrom
ericshape:add_tde_show
Draft

Add azmcp sql server conn-policy show and unit tests#799
ericshape wants to merge 2 commits intomicrosoft:mainfrom
ericshape:add_tde_show

Conversation

@ericshape
Copy link
Member

@ericshape ericshape commented Oct 14, 2025

What does this PR do?

Add azmcp sql server conn-policy show and unit tests

GitHub issue number?

[Link to the GitHub issue this PR addresses]

Pre-merge Checklist

  • Required for All PRs
    • Read contribution guidelines
    • PR title clearly describes the change
    • Commit history is clean with descriptive messages (cleanup guide)
    • Added comprehensive tests for new/modified functionality
    • Updated servers/Azure.Mcp.Server/CHANGELOG.md and/or servers/Fabric.Mcp.Server/CHANGELOG.md for product changes (features, bug fixes, UI/UX, updated dependencies)
  • For MCP tool changes:
    • One tool per PR: This PR adds or modifies only one MCP tool for faster review cycles
    • Updated servers/Azure.Mcp.Server/README.md and/or servers/Fabric.Mcp.Server/README.md documentation
    • Validate README.md changes using script at eng/scripts/Process-PackageReadMe.ps1. See Package README
    • Updated command list in /servers/Azure.Mcp.Server/docs/azmcp-commands.md and/or /docs/fabric-commands.md
    • For new or modified tool descriptions, ran ToolDescriptionEvaluator and obtained a score of 0.4 or more and a top 3 ranking for all related test prompts
    • For new tools associated with Azure services or publicly available tools/APIs/products, add URL to documentation in the PR description
  • Extra steps for Azure MCP Server tool changes:
    • Updated test prompts in /servers/Azure.Mcp.Server/docs/e2eTestPrompts.md
    • 👉 For Community (non-Microsoft team member) PRs:
      • Security review: Reviewed code for security vulnerabilities, malicious code, or suspicious activities before running tests (crypto mining, spam, data exfiltration, etc.)
      • Manual tests run: added comment /azp run mcp - pullrequest - live to run Live Test Pipeline

@joshfree joshfree added server-Azure.Mcp Azure.Mcp.Server tools-SQL Do Not Merge Do Not Merge / WIP PRs labels Oct 15, 2025
@joshfree joshfree moved this from Untriaged to In Progress in Azure MCP Server Oct 15, 2025
@joshfree joshfree added this to the 2025-11 milestone Oct 15, 2025
@joshfree
Copy link
Member

joshfree commented Oct 15, 2025

Let's hold new tools until main opens up for 2.0-beta

@joshfree joshfree removed the Do Not Merge Do Not Merge / WIP PRs label Oct 30, 2025
@fanyang-mono
Copy link
Contributor

fanyang-mono commented Nov 14, 2025

Make sure to update consolidated-tools.json](https://github.com/microsoft/mcp/blob/main/core/Azure.Mcp.Core/src/Areas/Server/Resources/consolidated-tools.json). You can find instructions in https://github.com/microsoft/mcp/blob/main/CONTRIBUTING.md

@joshfree joshfree modified the milestones: 2025-11, 2026-01 Jan 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@achyuth-ms achyuth-ms Awaiting requested review from achyuth-ms achyuth-ms will be requested when the pull request is marked ready for review achyuth-ms is a code owner

@jeremyfrosti jeremyfrosti Awaiting requested review from jeremyfrosti jeremyfrosti will be requested when the pull request is marked ready for review jeremyfrosti is a code owner

Copilot code review Copilot Awaiting requested review from Copilot Copilot will automatically review once the pull request is marked ready for review

At least 1 approving review is required to merge this pull request.

Assignees

@ericshape ericshape

Labels

server-Azure.Mcp Azure.Mcp.Server tools-SQL

Projects

Azure MCP Server
Status: In Progress

Milestone

2026-01

Development

Successfully merging this pull request may close these issues.

3 participants

@ericshape @joshfree @fanyang-mono